[
https://issues.apache.org/jira/browse/BOOKKEEPER-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233475#comment-13233475
]
[email protected] commented on BOOKKEEPER-188:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4414/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
This is a very straight forward refactor. The one functional change is that
extractMetaFromEntryLogs now call extractMetaFromEntryLog rather than having
duplicate logic in each.
This addresses bug BOOKKEEPER-188.
https://issues.apache.org/jira/browse/BOOKKEEPER-188
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
8da372e
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
23f02bc
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java
96df89a
Diff: https://reviews.apache.org/r/4414/diff
Testing
-------
Thanks,
Ivan
> Garbage collection code is in the wrong place
> ---------------------------------------------
>
> Key: BOOKKEEPER-188
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-188
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-188.diff
>
>
> There's a lot of garbage collection code in the wrong place in EntryLogger.
> extractMetaFromEntryLogs, and EntryLogMetadata are only every used in the GC
> Thread. So they should move there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
