[
https://issues.apache.org/jira/browse/BOOKKEEPER-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254508#comment-13254508
]
jirapos...@reviews.apache.org commented on BOOKKEEPER-191:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4731/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
currently, hub server write entries to only one ledger, if a topic doesn't
change ownership, all entries will be added to this ledger. so those consumed
messages don't have chance to be garbage collected.
This addresses bug BOOKKEEPER-191.
https://issues.apache.org/jira/browse/BOOKKEEPER-191
Diffs
-----
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
15162b0
hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java
791c704
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java
95ee04c
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookkeeperPersistenceManagerWhiteBox.java
47c7030
Diff: https://reviews.apache.org/r/4731/diff
Testing
-------
Thanks,
Sijie
> Hub server should change ledger to write, so consumed messages have chance to
> be garbage collected.
> ---------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-191
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-191
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BK-191.diff
>
>
> currently, hub server write entries to only one ledger, if a topic doesn't
> change ownership, all entries will be added to this ledger. so those consumed
> messages don't have chance to be garbage collected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
