----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4737/#review6935 -----------------------------------------------------------
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15468> I'd prefer if this was simply called Journal. JournalManager is a class in HDFS, so having it here also will muddle things in my mind. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15467> Should be private bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15466> Should be private bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15469> private bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15470> private bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15471> private bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15472> I would suggest calling the thread BookieJournal- so that it can be be identified when running a lot of other systems in a single process, such as for testing. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15473> never used, remove bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15474> It would be good to have a comment here stating what marking the log means. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15475> private bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15476> I would suggest calling this simply replay() bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java <https://reviews.apache.org/r/4737/#comment15477> There's an asymmetry between this and the method for reading, JournalScanner. This takes an entry, a ledgerId, and an entryId. JournalScanner only gets an entry buffer back. Logically Journal shouldn't care about entryid or ledgerid. I think logAddEntry should only have (ByteBuffer entry, WriteCallback cb, Object ctx) as the parameter list. - Ivan On 2012-04-16 13:57:54, Sijie Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4737/ > ----------------------------------------------------------- > > (Updated 2012-04-16 13:57:54) > > > Review request for bookkeeper. > > > Summary > ------- > > Currently we put all journal related operations in Bookie class. It would be > better to provide a journal manager to provide journal related operations. It > would make Bookie logic more clearly. > > Besides that, some admin tools like BOOKKEEPER-183 needs to provide could use > JournalManager to read/check journal files directly. > > > This addresses bug BOOKKEEPER-218. > https://issues.apache.org/jira/browse/BOOKKEEPER-218 > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > bbf561a > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieBean.java > fa5171b > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieMXBean.java > 8418469 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java > c172224 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieJournalRollingTest.java > e795fce > > Diff: https://reviews.apache.org/r/4737/diff > > > Testing > ------- > > > Thanks, > > Sijie > >
