[
https://issues.apache.org/jira/browse/BOOKKEEPER-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254736#comment-13254736
]
[email protected] commented on BOOKKEEPER-218:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4737/#review6935
-----------------------------------------------------------
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15468>
I'd prefer if this was simply called Journal. JournalManager is a class in
HDFS, so having it here also will muddle things in my mind.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15467>
Should be private
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15466>
Should be private
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15469>
private
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15470>
private
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15471>
private
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15472>
I would suggest calling the thread BookieJournal- so that it can be be
identified when running a lot of other systems in a single process, such as for
testing.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15473>
never used, remove
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15474>
It would be good to have a comment here stating what marking the log means.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15475>
private
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15476>
I would suggest calling this simply replay()
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
<https://reviews.apache.org/r/4737/#comment15477>
There's an asymmetry between this and the method for reading,
JournalScanner.
This takes an entry, a ledgerId, and an entryId.
JournalScanner only gets an entry buffer back.
Logically Journal shouldn't care about entryid or ledgerid. I think
logAddEntry should only have (ByteBuffer entry, WriteCallback cb, Object ctx)
as the parameter list.
- Ivan
On 2012-04-16 13:57:54, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4737/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-16 13:57:54)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently we put all journal related operations in Bookie class. It would
be better to provide a journal manager to provide journal related operations.
It would make Bookie logic more clearly.
bq.
bq. Besides that, some admin tools like BOOKKEEPER-183 needs to provide could
use JournalManager to read/check journal files directly.
bq.
bq.
bq. This addresses bug BOOKKEEPER-218.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-218
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
bbf561a
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieBean.java
fa5171b
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieMXBean.java
8418469
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java
PRE-CREATION
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java
c172224
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieJournalRollingTest.java
e795fce
bq.
bq. Diff: https://reviews.apache.org/r/4737/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> Provide journal manager to manage journal related operations
> ------------------------------------------------------------
>
> Key: BOOKKEEPER-218
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-218
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-218.diff
>
>
> Currently we put all journal related operations in Bookie class. It would be
> better to provide a journal manager to provide journal related operations. It
> would make Bookie logic more clearly.
> Besides that, some admin tools like BOOKKEEPER-183 needs to provide could use
> JournalManager to read/check journal files directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
