[
https://issues.apache.org/jira/browse/BOOKKEEPER-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257115#comment-13257115
]
Sijie Guo commented on BOOKKEEPER-173:
--------------------------------------
@Flavio,
> If setNumWorkerThreads is called after the BookKeeper object is constructed,
> then it has no effect on the number of threads in the pool.
yes, ur right. How about clarifying it in the documentation of this method?
> Also, it would be good to add a description of these options to the
> documentation.
will do it in the new patch.
> Uncontrolled number of threads in bookkeeper
> --------------------------------------------
>
> Key: BOOKKEEPER-173
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-173
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Philipp Sushkin
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-173.patch
>
>
> I am not sure if it is a but or not.
> Say, I do have pc with 256 cores, and there is following code in bookkeeper:
> {code:title=BookKeeper.java|borderStyle=solid}
> OrderedSafeExecutor callbackWorker = new
> OrderedSafeExecutor(Runtime.getRuntime().availableProcessors());
> OrderedSafeExecutor mainWorkerPool = new OrderedSafeExecutor(Runtime
> .getRuntime().availableProcessors());
> {code}
> As I understand, callbackWorker is not used at all, so it could be removed.
> Also could be required to get more control over mainWorkerPool (say, extract
> interface + pass instance through contructor).
> Myabe there are other places in library where some thread pools are created
> without ability to reuse existing thread pools in application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
