[
https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272239#comment-13272239
]
Ivan Kelly commented on BOOKKEEPER-251:
---------------------------------------
The shape/functionality of the patch are good. I have a few comments on the
names though. I think it would be clearer to name isLogExisted() as a)
logExists() or b) doesLogExist(). I prefer a).
> Noise error message printed when scanning entry log files those have been
> garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff
>
>
> currently, due to the messy scan mechanism deployed by garbage collector
> thread. following noise error message would be printed when scanning those
> entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO
> [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log
> meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] -
> Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN
> [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception
> when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at
> org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at
> org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at
> org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at
> org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at
> org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at
> org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
