[
https://issues.apache.org/jira/browse/BOOKKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285705#comment-13285705
]
Ivan Kelly commented on BOOKKEEPER-273:
---------------------------------------
Two small niggles with the patch.
a) the javadoc should specify BKException.BKNoSuchLedgerExistsException rather
than BKNoSuchLedgerExistsException, so that javadoc can generate a link for it.
(mvn javadoc:aggregate generates the javadoc btw)
b) the else should be on the same line. Use zookeeper's coding standard, which
in turn uses the sun standard. [1][2]
[1] https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
[2]
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449
> LedgerHandle.deleteLedger() should be idempotent
> ------------------------------------------------
>
> Key: BOOKKEEPER-273
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-273
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Affects Versions: 4.1.0
> Reporter: Matteo Merli
> Priority: Minor
> Fix For: 4.1.0
>
> Attachments:
> 0001-BOOKKEEPER-273-LedgerHandle.deleteLedger-should-be-i.patch,
> 0001-BOOKKEEPER-273-LedgerHandle.deleteLedger-should-be-i.patch
>
>
> Deleting a non-existing ledger should silently succeed.
> Current behavior is to raise a ZKException, but it's not possible to know
> whether there was some error or the ledger does not exists anymore.
> This scenario will happen when a previous deleteLedger() call succeeded but
> the client crashed before updating its own ledger list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
