[
https://issues.apache.org/jira/browse/BOOKKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294346#comment-13294346
]
Ivan Kelly commented on BOOKKEEPER-183:
---------------------------------------
Looks good. A few comments.
- Implement ReadOnlyEntryLogger rather than adding a boolean flag.
- Put the hedwig message formatter in hedwig-server to avoid having the
protocol depend on bookkeeper-server.
- It would be nice if the StringEntryFormatter could print binary without
printing jargon for non-printable values. Maybe we could use ByteString from
protobuf once that's integrated.
> Provide tools to read/check data files in bookie server
> -------------------------------------------------------
>
> Key: BOOKKEEPER-183
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BK-183.diff, BOOKKEEPER-183.diff
>
>
> We have written some tools to read/check data files (including index file,
> journal files, entry log files) in bookie server, which helps user
> finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
