[
https://issues.apache.org/jira/browse/BOOKKEEPER-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399120#comment-13399120
]
Uma Maheswara Rao G commented on BOOKKEEPER-299:
------------------------------------------------
Thanks a lot Ivan, for your time.
Make sense to me for moving the code to client package.
One clarification: are you suggesting like LedgerFragmentReplicator will have
BookKeeperAdmin and call the required APIs? Why can't LedgerFragmentReplicator
is an helper class for BookKeeperAdmin for providing fragment replication
API's? one way we can reduce BookKeeperAdmin code also because we may add some
more code in future about other admin commands.
{quote}
Another thing which would be nice to change here, is that currently the
recovery code will try to recover all entries in parallel. I don't like this. I
think it would be better to do it in series, so that we don't overload the
server with a lot of read requests at once.
{quote}
Will do this. But this change will apply for BKadmin also as i am using common
peice of code for both ReplicationWorker and BKAdmin, is that fine?
> Provide LedgerFragmentReplicator which should replicate the fragments found
> from LedgerChecker
> ----------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-299
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-299
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.2.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-299.patch
>
>
> Replication worker requires LedgerFragmentReplicator for replicating the
> actula fragments found from Ledger checker.
> Most of the fragment replication code available in BookKeeperAdmin. We can
> refactor it to LedgerFragmentReplicator and use it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
