[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399121#comment-13399121
 ] 

Rakesh R commented on BOOKKEEPER-307:
-------------------------------------

simple and good fix.
I have one suggestion, few unused imports also exists in the BookieShell class. 
It would be good doing the cleanup now as we are touching the class.
{code}
import java.io.RandomAccessFile;
import java.util.List;
import org.apache.commons.configuration.ConfigurationException;
{code}
                
> BookieShell introduces 4 findbugs warnings
> ------------------------------------------
>
>                 Key: BOOKKEEPER-307
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-307
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-307.diff
>
>
> One is an empty store. The other is about synchronized access to the journal. 
> Easy fixes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to