[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410515#comment-13410515
 ] 

Ivan Kelly commented on BOOKKEEPER-329:
---------------------------------------

Hmmm, i disagree with needing it for localbookie, but we will need it for 
auditor pretty soon. The error needs to be more explicit though. If the 
<service> is not provided, we should error early and error loudly. Also, there 
are things which we should never ever ever daemonize, such as console. 

I think for there should be a list of approved daemonizable commands, 
{code}
case $command in 
    bookie|auditor)
        echo doing $command
        ;;
    *)
        echo service must be one of bookie,auditor
        ;;
esac
{code}
                
> provide stop scripts for hub server
> -----------------------------------
>
>                 Key: BOOKKEEPER-329
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: hedwig-server
>    Affects Versions: 4.0.0, 4.1.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-329.diff
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar 
> script to start/stop hub server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to