[
https://issues.apache.org/jira/browse/BOOKKEEPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414647#comment-13414647
]
Mridul Muralidharan commented on BOOKKEEPER-331:
------------------------------------------------
bq. 1) all patches need to rebase to latest trunk. a) applying
hedwig-protocol.patch.3 failed on PubSubProtocol.java; b) applying
hedwig-server.patch.3. it failed to compile test cases due to you don't change
TestCallback to return message id in TestBookKeeperPersistenceManager (which is
a new test case added in BOOKKEEPER-302).
Will do, I will try to regenerate tonight or latest by tomorrow.
bq. 2) need a test case to test returning message seq id. you could leverage
TestPubSubClient in hedwig-server module. those test cases could be publish &
asyncPublish several messages and checking the messages id returned by publish
and asyncPublish equals to the message seq id received by a subscriber.
This slipped my mind, will add to the testcase - thanks for the pointer.
bq. 3) hedwig-protocol.patch : why not use the patch in BOOKKEEPER-78 instead
of combining it together? so it could make each jira focus on its changes.
Since message headers are a pre-requisite for this set of JIRA's, we can commit
them only after the headers are supported (either via this or BOOKKEEPER-78)
Do you want me to hold off until BOOKKEEPER-78 is committed ?
bq. it would be better to add 'TODO' on the above comment.
Yes, I will add.
bq. since PublishReponse is an optional filed in ResponseBody, do we need to
check whether ResponseBody#hasPublishResponse() before #getPublishResponse() ?
Yes, should check and return null if absent. I was assuming protobuf does the
same, but it makes sense to be explicit.
> Let hedwig support returning message seq id for publish requests.
> -----------------------------------------------------------------
>
> Key: BOOKKEEPER-331
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-331
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client, hedwig-server
> Reporter: Sijie Guo
> Fix For: 4.2.0
>
>
> Let hedwig support returning message seq id for published messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
