[
https://issues.apache.org/jira/browse/BOOKKEEPER-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420527#comment-13420527
]
Uma Maheswara Rao G commented on BOOKKEEPER-326:
------------------------------------------------
@Rakesh, change looks good to me.
I have some observations in test but they are not be really related to this
chnage alone.
In Tests: Default BookieRecoveryTest taking the number of bookies as argument
in constructors.
So, setUp will start the number of bookies for testCase. If we start any
bookies our own, do we need to clean all the resources( ex: bsConf) to that
Bookie our own? what is the contract here?
Otherwise I have seen one problem with restartBookies API. This API is useing
the bsConf for restarting the bookies. But tearDown is leaving that extra
started Bookies confs in bsConf. So, restartBookies may start that older
bookies also.
In my opinion, we should clean that bsConf in tearSown or stopBKCluster.
Since this change is not related to this particular change, does it make sense
to file a separate JIRA? Why I raised this concerne here is, when I saw the
test code observed there are extra bookies started in this test.
What do you say Sijie?
Also, I am not sure, that test will reproduce the case, but it may be worth
keeping the test as he is using newer clients. I am not sure, is there a better
way to automat this deadLock here by tests. So,keeping this test should be ok
from me.
Thanks
Uma
> DeadLock during ledger recovery
> --------------------------------
>
> Key: BOOKKEEPER-326
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-326
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Vinay
> Priority: Blocker
> Attachments: BK_DeadLock.log, BOOKKEEPER-326.1.patch,
> BOOKKEEPER-326.2.patch, BOOKKEEPER-326.part2.diff, BOOKKEEPER-326.patch
>
>
> Deadlock found during ledger recovery. please find the attached thread dump.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
