-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4731/
-----------------------------------------------------------
(Updated Aug. 9, 2012, 9:14 a.m.)
Review request for bookkeeper.
Changes
-------
update the patch to address Ivan's comments.
Description
-------
currently, hub server write entries to only one ledger, if a topic doesn't
change ownership, all entries will be added to this ledger. so those consumed
messages don't have chance to be garbage collected.
This addresses bug BOOKKEEPER-191.
https://issues.apache.org/jira/browse/BOOKKEEPER-191
Diffs (updated)
-----
hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java
c8c6610
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java
873fecd
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookkeeperPersistenceManagerWhiteBox.java
eac141c
Diff: https://reviews.apache.org/r/4731/diff/
Testing
-------
Thanks,
Sijie Guo
