[
https://issues.apache.org/jira/browse/BOOKKEEPER-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432924#comment-13432924
]
Uma Maheswara Rao G commented on BOOKKEEPER-246:
------------------------------------------------
Latest Patch looks great.
Some comments regarding Rakesh points:
{quote}
LedgerUnderreplicationManager presently doesn't have any close apis and its
taking zkclient externally?
{quote}
We should handle that zkc cleanups from outside of
LedgerUnderreplicationManager as it is taking zkc from out side.
I think what Rakesh pointing is,
on LedgerUnderreplicatedManager destroy, how we will do the cleanup?
cleaning the EPHEMERAL etc, as that nodes got created by
LedgerUnderreplicatedManager.
So, cleanUp API will be required inside LedgerUnderreplicatedManager to clean
the EPHEMERAL nodes which are created by him? (this will be the case for
graceful handling.)
On suddent crashes, anayway that nodes will get cleaned as process dies.
> Recording of underreplication of ledger entries
> -----------------------------------------------
>
> Key: BOOKKEEPER-246
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-246
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-246.diff, BOOKKEEPER-246.diff,
> BOOKKEEPER-246.diff, BOOKKEEPER-246.diff
>
>
> This JIRA is to decide how to record that entries in a ledger are
> underreplicated.
> I think there is a common understanding (correct me if im wrong), that
> rereplication can be broken into two logically distinct phases. A) Detection
> of entry underreplication & B) Rereplication.
> This subtask is to handle the interaction between these two stages. Stage B
> needs to know what to rereplicate; how should Stage A inform it?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
