[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438729#comment-13438729
]
Sijie Guo commented on BOOKKEEPER-300:
--------------------------------------
{quote}
of-course, for layoutVersion 3 instanceId will not be present, because it will
be added only in layoutVersion 4 (current patch) onwards. So no need to check
for it instanceId in version 3.
instanceId must be present for further versions.
{quote}
What happened if a version 3 cookie access version 4 bookkeeper? the code is
used to validate cookie, you need to cover the cases, I assumed.
{quote}
You're trying to suggest me to still have LedgerManager.format() and in the
abstract format should use 'ZKUtils.deleteRecusive()'..?
{quote}
you could use asyncProcessLedgers or ZKUtils.deleteRecursive. either is OK.
{quote}
You mean to say, implement complete format() in 'ledger manager factory' itself
instead of implementing under 'ledger manager'..?
{quote}
yes.
{quote}
These will be automatically created when
LedgerManagerFactory.newLedgerManagerFactory(..) is called. Do you think we
need to call this after format..?
{quote}
format means cleaning old data and creating a new one. so I think creating a
new one would be needed.
{quote}
I think, we can add one more command in BookieShell as "bkadmin", which can
take the arguments "recover" or "formatZk" and corresponding additional
arguments if required. In that case BookKeeperTools may not be required anymore.
{quote}
it is OK.
> Create Bookie format command
> ----------------------------
>
> Key: BOOKKEEPER-300
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-300
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Rakesh R
> Attachments: BOOKKEEPER-300.patch, BOOKKEEPER-300.patch
>
>
> Provide a bookie format command. Then the admin would just have to run the
> command on each machine, which will prepare the bookie env
> +Zookeeper paths (znodes):+
> - ledger's root path
> - bookie's available path
> +Directories:+
> - Journal directories
> - Ledger directories
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
