[
https://issues.apache.org/jira/browse/BOOKKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440208#comment-13440208
]
Ivan Kelly commented on BOOKKEEPER-333:
---------------------------------------
I like these changes a lot. Seems very general, so a lot can be done with it. I
have a 2 small comments.
- I think there should be an explicit exception for an invalid filter, rather
than UnexpectedConditionException.
- In SubscribeHandler, don't catch Throwable. This also catchs
RuntimeExceptions which are usually a sign of programming error.
> server-side message filter
> --------------------------
>
> Key: BOOKKEEPER-333
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-333
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-333.patch, BOOKKEEPER-333.patch
>
>
> Support running message filter on server-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
