[
https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445794#comment-13445794
]
Ivan Kelly commented on BOOKKEEPER-334:
---------------------------------------
I think startDeliveryWithFilter would be a better name.
There's new functionallity which replaces the provided subscriptionpreferences
which that on the server. This should be documented in the javadoc, that any
SubscriptionPreferences specified for an ATTACH will be be ignored in favour of
those specified in the first CREATE.
What is the usecase? Why is this necessary if there are filters on the server?
startDelivery should throw an exception if messageFilter or messageHandler is
null.
Otherwise, the patch looks good.
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch, BOOKKEEPER-334.patch,
> BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
