[ https://issues.apache.org/jira/browse/BOOKKEEPER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446098#comment-13446098 ]
Uma Maheswara Rao G commented on BOOKKEEPER-386: ------------------------------------------------ Ok, thanks a lot Ivan. I will take a look at this patch. I actually expected this ledger open detection from LedgerChecker, when we were implementing that. I think that time we were in diff [thought|https://issues.apache.org/jira/browse/BOOKKEEPER-247?focusedCommentId=13405001&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13405001]. I am fine with this approach too. I will review it tomorrow. > It should not be possible to replicate a ledger fragment which is at the end > of an open ledger > ---------------------------------------------------------------------------------------------- > > Key: BOOKKEEPER-386 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-386 > Project: Bookkeeper > Issue Type: Sub-task > Reporter: Ivan Kelly > Assignee: Uma Maheswara Rao G > Fix For: 4.2.0 > > Attachments: BOOKKEEPER-386.diff > > > BookKeeperAdmin#replicateLedgerFragment has introduced a code path whereby it > is possible to rereplicate a fragment which is at the end of an open ledger. > This is dangerous as it could cause the lose of entries, as the client could > still be writing when we change the ensemble. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira