[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stu Hood updated BOOKKEEPER-32:
-------------------------------

    Attachment: 32.diff

Ok, correction: only the toString'ing of binary data in BookieServer was 
actually that bad: moved that one into a trace-level conditional, and had it 
log hex rather than raw binary data.

More than 95% of statements were being properly wrapped, but in many cases 
there was wrapping where it was unnecessary (ie, for logging of 0/1/2 zero-cost 
arguments.)
                
> Clean up LOG.debug statements
> -----------------------------
>
>                 Key: BOOKKEEPER-32
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-client, bookkeeper-server
>            Reporter: Flavio Junqueira
>            Assignee: Stu Hood
>         Attachments: 32.diff
>
>
> There are a couple of LOG.debug statements in the client package that are not 
> in an if block under isDebugEnabled(). They are invoked frequently, so they 
> affect performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to