[
https://issues.apache.org/jira/browse/BOOKKEEPER-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454939#comment-13454939
]
Rakesh R commented on BOOKKEEPER-403:
-------------------------------------
Hi Ivan, its nice idea of abstraction and looks good. Just few comments:
- @Override tag is missing in OrderedSafeGenericCallback implemetation
{code}
public final void operationComplete(final int rc, final T result) {
executor.submitOrdered(orderingKey, new SafeRunnable() {
{code}
- I feel, following places also could use OrderedSafeGenericCallback. Whats
your opinion?
{code}
LedgerOpenOp.public void operationComplete(int rc, LedgerMetadata metadata)
LedgerHandle.
rereadMetadata(new GenericCallback<LedgerMetadata>() {
@Override
public void operationComplete(int rc, LedgerMetadata newMeta) {
if (rc != BKException.Code.OK) {
cb.operationComplete(rc, null);
} else {
metadata = newMeta;
recover(cb);
}
{code}
> ReReadMetadataCb is not executed in the thread responsible for that ledger
> --------------------------------------------------------------------------
>
> Key: BOOKKEEPER-403
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-403
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Affects Versions: 4.2.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.2.0
>
> Attachments: BK-403.patch, BOOKKEEPER-403.diff
>
>
> Attached a patch to execute the callback in bk.mainWorkerPool instead of on
> the zookeeper thread.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
