> On Sept. 19, 2012, 12:07 a.m., Sijie Guo wrote: > > hedwig-server/conf/hwenv.sh, line 24 > > <https://reviews.apache.org/r/7118/diff/2-3/?file=156124#file156124line24> > > > > is there any consideration that you uncommented HEDWIG_SERVER_CONF and > > HEDWIG_REGION_CLIENT_CONF ? > > Aniruddha Laud wrote: > In the previous comment you mentioned uncommenting the value. Hence the > change. I've updated the diff to comment both values.
oh. it is my mistake. sorry for troubling you. - Sijie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7118/#review11676 ----------------------------------------------------------- On Sept. 19, 2012, 5:06 a.m., Aniruddha Laud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7118/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2012, 5:06 a.m.) > > > Review request for bookkeeper, Ivan Kelly and Sijie Guo. > > > Description > ------- > > Make the region manager's client configurable. > > https://issues.apache.org/jira/browse/BOOKKEEPER-397 > > > Diffs > ----- > > hedwig-server/bin/hedwig e3b06cc > hedwig-server/conf/hw_region_client.conf PRE-CREATION > hedwig-server/conf/hwenv.sh a0aeb84 > > hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java > 5036154 > > hedwig-server/src/main/java/org/apache/hedwig/server/regions/HedwigHubClientFactory.java > fa240e2 > > hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java > 5d64498 > > Diff: https://reviews.apache.org/r/7118/diff/ > > > Testing > ------- > > > Thanks, > > Aniruddha Laud > >
