[
https://issues.apache.org/jira/browse/BOOKKEEPER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460571#comment-13460571
]
Ivan Kelly commented on BOOKKEEPER-364:
---------------------------------------
HedwigClientImpl uses AbstractHChannelManager, where it should only use
HChannelManager. It should be possible for someone to implement HChannelManager
without having to extend AbstractHChannelManager and just connect it up to the
HedwigClientImpl. Would it be possible to move everything which uses
AbstractHChannelManager into a different package
(org.apache.hedwig.client.netty.abstract), as at the moment, it's unclear which
things are generic and which are tied to AbstractHChannelManager. I would guess
you could move everything but HedwigClientImpl, HedwigSubscriber,
HedwigPublisher, NetUtils, HChannel & HChannelManager.
> re-factor hedwig java client to support both one-subscription-per-channel and
> multiplex-subscriptions-per-channel.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-364
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-364
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-364.diff, BOOKKEEPER-364.diff
>
>
> Currently Hedwig client is coupled with the design of one subscription per
> channel. In order to multiplex multiple subscription into one channel, it
> would be better to refine the Hedwig java client code to provide better
> interface to support both mode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
