----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7479/#review12289 -----------------------------------------------------------
Great job, Stu. I have just a few minor points. hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java <https://reviews.apache.org/r/7479/#comment26058> I was thinking that it might be a good idea to add some comments here about how to use this base class. These comments would be to help new developers to write tests. What do you think? hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigRegion.java <https://reviews.apache.org/r/7479/#comment26055> Why would client be null here? hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigRegion.java <https://reviews.apache.org/r/7479/#comment26056> Same question about being null. I'm just wondering why this check was not here before. hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestUpdateSubscriptionState.java <https://reviews.apache.org/r/7479/#comment26057> Any particular reason for dropping it to 10? It was 100 before. - fpj On Oct. 8, 2012, 8:57 p.m., Stu Hood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7479/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 8:57 p.m.) > > > Review request for bookkeeper, Ivan Kelly and Aniruddha Laud. > > > Description > ------- > > https://issues.apache.org/jira/browse/BOOKKEEPER-423 > > > This addresses bug BOOKKEEPER-423. > https://issues.apache.org/jira/browse/BOOKKEEPER-423 > > > Diffs > ----- > > hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java > 523ecdc > > hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java > 4ec0d50 > > hedwig-server/src/test/java/org/apache/hedwig/server/delivery/TestThrottlingDelivery.java > 66e9ff3 > > hedwig-server/src/test/java/org/apache/hedwig/server/filter/TestMessageFilter.java > ae46be2 > > hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java > 02b4503 > > hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigRegion.java > 0b1851e > > hedwig-server/src/test/java/org/apache/hedwig/server/persistence/MessageBoundedPersistenceTest.java > 03b40f3 > > hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestDeadlock.java > 114e0c5 > > hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestUpdateSubscriptionState.java > d21eef3 > > hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestConcurrentTopicAcquisition.java > 956d31c > > Diff: https://reviews.apache.org/r/7479/diff/ > > > Testing > ------- > > > Thanks, > > Stu Hood > >
