-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7560/
-----------------------------------------------------------
Review request for bookkeeper, fpj, Uma Maheswara Rao G, Ivan Kelly, and Rakesh
R.
Description
-------
The current bookkeeper server is single threaded. The same thread handles reads
and writes. When reads are slow (possibly because of excessive seeks), add
entry operations suffer in terms of latencies. Providing separate read and
write threads helps in reducing add entry latencies and increasing throughput
even when we're facing slow reads. Having a single read thread also results in
low disk utilization because seeks can't be ordered efficiently by the OS.
Multiple read threads would help in improving the read throughput.
This addresses bug BOOKKEEPER-429.
https://issues.apache.org/jira/browse/BOOKKEEPER-429
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
9a62264
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
e2260fd
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedReadChannel.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
87b0c66
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
77e08bf
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java
558e8cf
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java
3c39404
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerEntryPage.java
8395a2f
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
4af5dec
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
2b7466f
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/MultiPacketProcessor.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
05acacf
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java
PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java
3d59857
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java
dc5eefa
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultipleThreadReadTest.java
PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/NIOServerFactoryTest.java
bdcb7a2
Diff: https://reviews.apache.org/r/7560/diff/
Testing
-------
Thanks,
Aniruddha Laud