[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481031#comment-13481031
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-409:
------------------------------------------------

{code}
    private void startReplicationService() throws CompatibilityException,
+            KeeperException, InterruptedException, IOException,
+            UnavailableException {
+        int index = -1;
+        for (BookieServer bserver : bs) {
+            startAutoRecovery(bserver, bsConfs.get(++index));
+        }
+    }
{code}
One quick comment: how about moving such functionality to 
BookKeeperClusterTestCase, as we are starting the BK cluster and ZK clusters 
from this base testcase and all others will use it. But here Auditor should be 
started on demand. May we can have another ctor or just expose the API to start 
by just passing the BK index.

I did not go through the patch completely. I can post full comments by tomorrow 
if any. Thanks Rakesh for the patch.
                
> Integration Test - Perform bookie rereplication cycle by Auditor-RW processes
> -----------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-409
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-409
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-auto-recovery
>    Affects Versions: 4.2.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>              Labels: test
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-409-1.patch, BOOKKEEPER-409.patch
>
>
> The idea is to perform integration testing of entire re-replication module : 
> Auditor-RW processes

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to