----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7314/#review12653 -----------------------------------------------------------
bookkeeper-server/pom.xml <https://reviews.apache.org/r/7314/#comment26988> bk-server has added guava recently, so this is unnecessary. bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreCursor.java <https://reviews.apache.org/r/7314/#comment26990> this also needs a method to notify that there are no more entries. bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreScannableTable.java <https://reviews.apache.org/r/7314/#comment26986> why do we have scannable table and normal table? what happens if a client expects a scannable table and the implementation doesnt support it? I suggest there should be only one type of table, otherwise the contract we provide to the client is ambiguous. bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreTable.java <https://reviews.apache.org/r/7314/#comment26983> i dont think we need a put and a versionedPut. I think every write should be versionde. in the past, when they have not been, we have run into cases where we found that they really should be versioned. bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreTable.java <https://reviews.apache.org/r/7314/#comment26984> The use of VersionedValue here is a little strange. The Version is the version of the data that is in the store, the value is new value you want to write. as such, they should be two separate parameters. bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreTableItem.java <https://reviews.apache.org/r/7314/#comment26985> you cant have copyright notices in ASF code bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/Value.java <https://reviews.apache.org/r/7314/#comment26987> value should only be a byte[]. adding fields like this does, overexpands the scope of the change without a strong need. - Ivan Kelly On Sept. 27, 2012, 9:21 a.m., Jiannan Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7314/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2012, 9:21 a.m.) > > > Review request for bookkeeper. > > > Description > ------- > > We need a MetaStore interface which easy for us to plugin different scalable > k/v storage, such as HBase. > > > This addresses bug BOOKKEEPER-204. > https://issues.apache.org/jira/browse/BOOKKEEPER-204 > > > Diffs > ----- > > bookkeeper-server/pom.xml c608361 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MSException.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetaStore.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreCallback.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreCursor.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreException.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreFactory.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreScannableTable.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreTable.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreTableItem.java > PRE-CREATION > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/Value.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/VersionedValue.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/mock/MockMetaStore.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/mock/MockMetastoreCursor.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/mock/MockMetastoreTable.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/metastore/MetastoreScannableTableAsyncToSyncConverter.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/metastore/MetastoreTableAsyncToSyncConverter.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/metastore/TestMetaStore.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/7314/diff/ > > > Testing > ------- > > > Thanks, > > Jiannan Wang > >
