[
https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483989#comment-13483989
]
Ivan Kelly commented on BOOKKEEPER-441:
---------------------------------------
Patch looks good, and its a nice cleanup. Two comments, could you rename
_top2sub2seq to top2seq2subBackup. Underscores are not very informative. Also,
since after readSubscriptions, the sub info is put back into top2sub2seq,
_top2sub2seq.get() in readSubscriptions should be _top2sub2seq.remove()
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.2.0
>
> Attachments: BackupTop2Sub2Seq.patch, BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear
> top2sub2seq. The intent is to allow readSubscription to get the information
> there. This introduce dependency outside the class, evidence is that general
> ReleaseOp has to use a boolean parameter which targets this implementation
> detail. Further, this prevents Acquire-topic to notify listeners
> (notifyFirstLocalSubscribe is not called) of first subscription to act
> appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
