-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7731/
-----------------------------------------------------------
(Updated Oct. 25, 2012, 4:52 p.m.)
Review request for bookkeeper, Ivan Kelly, Sijie Guo, and Aniruddha Laud.
Changes
-------
Updated patch per comment
Description
-------
On topic loss, InMemorySubscriptionManager currently does not clear
top2sub2seq. The intent is to allow readSubscription to get the information
there. This introduce dependency outside the class, evidence is that general
ReleaseOp has to use a boolean parameter which targets this implementation
detail. Further, this prevents Acquire-topic to notify listeners
(notifyFirstLocalSubscribe is not called) of first subscription to act
appropriately.
This change address the issue.
This addresses bug BOOKKEEPER-441.
https://issues.apache.org/jira/browse/BOOKKEEPER-441
Diffs (updated)
-----
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
5552265
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/InMemorySubscriptionManager.java
1400e49
Diff: https://reviews.apache.org/r/7731/diff/
Testing
-------
Unit tests
Thanks,
Yixue (Andrew) Zhu
