[
https://issues.apache.org/jira/browse/BOOKKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484848#comment-13484848
]
Uma Maheswara Rao G commented on BOOKKEEPER-425:
------------------------------------------------
I just tried this patch in my environment. Applied cleanly for me with clean
update.
{noformat}
uma@uma-PC /cygdrive/e/BK-trunk
$ cat 0001-BOOKKEEPER-425-Cleanup-up-address-generation.patch |patch -p0
patching file bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Booki
e.java
patching file bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Cooki
e.java
patching file bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Ledge
rMetadata.java
patching file bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/Bookie
Server.java
patching file bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/Bookie
ServerBean.java
patching file bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/
AutoRecoveryMain.java
patching file bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/
BookieLedgerIndexer.java
patching file bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringU
tils.java
patching file bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/Booki
eInitializationTest.java
patching file bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/
AuditorBookieTest.java
patching file bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/
AuditorLedgerCheckerTest.java
{noformat}
@Flavio, could you please clean your source and update once? Not sure what
might be the actual cause in your env.
> Cleanup Bookie id generation
> ----------------------------
>
> Key: BOOKKEEPER-425
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-425
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-425-Cleanup-up-address-generation.patch,
> BOOKKEEPER-425.diff
>
>
> Bookie id generation (InetAddress.getLocalHost().getHostAddress() + ":" +
> port) is scattered all over the place. It would be better to have it
> centrallized somewhere in a static call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
