[
https://issues.apache.org/jira/browse/BOOKKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487692#comment-13487692
]
Ivan Kelly commented on BOOKKEEPER-362:
---------------------------------------
Patch is nice. To clarify, the new behaviour is, if a region is down and I
subscribe, the subscribe will fail if I haven't subscribed to the other region
before, but will succeed if I have?
I have a few style comments.
You added a TODO in RegionManager, create a jira for this, as TODOs tend to get
forgotten.
In RegionManager, some logs have had their indentation messed up. Also, add if
blocks should use curlies, even if they are single line.
Mark synchronous as deprecated in the proto file.
I think the following renames would be better.
checkTopicSubscribedToRegion -> getTopicSubscribedToRegion(). callback should
be a Callback<Boolean>.
setTopicUnsubscribedToRegion -> unsetTopicSubscribedToRegion()
I agree with Sijie about the Versioned stuff. It should be consistent with the
other managers.
> Local subscriptions fail if remote region is down
> -------------------------------------------------
>
> Key: BOOKKEEPER-362
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-362
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Reporter: Aniruddha
> Assignee: Yixue (Andrew) Zhu
> Priority: Critical
> Labels: hedwig
> Fix For: 4.2.0
>
> Attachments: rebase_remoteregion.patch, rebase_remoteregion.patch
>
>
> Currently, local subscriptions fail if the remote region hubs are down, even
> if the local hub has subscribed to the remote topic previously. Because of
> this, one region cannot function independent of the other.
> A more detailed discussion related to this can be found here
> http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201208.mbox/%3cCAOLhyDQSOF+Y+pvnyrd-HJRq1YEr=c8ok_b3_mr81r1g-9m...@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
