----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7733/#review13025 -----------------------------------------------------------
Ship it! looks good to me. +1 thanks Ivan. - Sijie Guo On Oct. 31, 2012, 3:32 p.m., Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7733/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2012, 3:32 p.m.) > > > Review request for bookkeeper. > > > Description > ------- > > The code to handle the state of a single entry read request is scattered all > over PendingReadOp. Some even leaks into LedgerEntry. This jira is to > refactor this code into one place to make speculative reads easier to > implement. > > > This addresses bug BOOKKEEPER-444. > https://issues.apache.org/jira/browse/BOOKKEEPER-444 > > > Diffs > ----- > > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java > 1f4547e > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java > c8e814c > > Diff: https://reviews.apache.org/r/7733/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Kelly > >
