----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7749/#review13337 -----------------------------------------------------------
Ship it! Ship It! - Rakesh R On Oct. 31, 2012, 5:57 p.m., Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7749/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2012, 5:57 p.m.) > > > Review request for bookkeeper. > > > Description > ------- > > Scenario: > > 1) Start three bookies. Create ledger with ensemblesize=3, quorumsize=2 > 2) Add 100 entries to this ledger > 3) Make first bookie down and read the entries from 0-99 > > Output: Each entry is going to fetch from the failed bookie and is waiting > for the bookie connection timeout, only after failure going to next bookie. > This is affecting the read entry performance. > > Impact: Namenode switching time will be affected by adding this failed bookie > readTimeOut also. > > > This addresses bug BOOKKEEPER-336. > https://issues.apache.org/jira/browse/BOOKKEEPER-336 > > > Diffs > ----- > > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java > c8e814c > > bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java > 8443c27 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestSpeculativeRead.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java > 2f39536 > > Diff: https://reviews.apache.org/r/7749/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Kelly > >
