[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496932#comment-13496932
 ] 

Sijie Guo commented on BOOKKEEPER-460:
--------------------------------------

I agreed putting in src/test/java/org/apache/bookkeeper/util as Flavio 
proposed, other than in bookie package.
                
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
>                 Key: BOOKKEEPER-460
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
>             Project: Bookkeeper
>          Issue Type: Test
>          Components: bookkeeper-server
>            Reporter: Fangmin Lv
>            Priority: Trivial
>         Attachments: BOOKKEEPER-460.diff
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade 
> bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the 
> Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
>     for (File f : ledgerDirectory.listFiles()) {
>         assertFalse("Found the entry log file (0.log) that should have been 
> deleted in ledgerDirectory: " 
>             + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
>     }
> }
> {code} 
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to