[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497280#comment-13497280
 ] 

Flavio Junqueira commented on BOOKKEEPER-445:
---------------------------------------------

I've never heard of this before, but I have seen LOG messages severely 
impacting performance because of strings generated unnecessarily and that one 
reason for adding the if blocks. How can we make sure that this is doing what 
it is supposed to do? I couldn't find anything in the documentation.
                
> LOG.trace calls in Bookie.java
> ------------------------------
>
>                 Key: BOOKKEEPER-445
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Minor
>         Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to