[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509080#comment-13509080
 ] 

Flavio Junqueira edited comment on BOOKKEEPER-399 at 12/3/12 9:43 PM:
----------------------------------------------------------------------

+1, The patch is simple and BookkeeperPersistenceManager is exercised in other 
tests, so I haven't felt the need of another test case. If we were to introduce 
a test case here, it could be perhaps to make sure that we are able to use 
different values of read and write quorums and that invalid values cause an 
exception. If anyone thinks that we need one or more test cases for this, 
please create another jira.
                
      was (Author: fpj):
    +1, The patch is simple and BookkeeperPersistenceManager is exercised in 
other tests, so I haven't felt the need of another test case. If we were to 
introduce a test case here, it could be perhaps to make sure that we are able 
to use different values of read and write quorums and that invalid values cause 
an exception. If anyone thinks that we need one more test cases for this, 
please create another jira.
                  
> Let hub server configure write quorum and ack quorum.
> -----------------------------------------------------
>
>                 Key: BOOKKEEPER-399
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-399
>             Project: Bookkeeper
>          Issue Type: New Feature
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>            Priority: Minor
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-399.diff
>
>
> since we support ack quorum in BOOKKEEPER-208, it would be better to let hub 
> server could configure it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to