[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509826#comment-13509826
 ] 

Flavio Junqueira commented on BOOKKEEPER-483:
---------------------------------------------

Perhaps I don't understand very well what's going on and my observation might 
be naive. I thought that with the pre-commit I was supposed to see it because 
it runs with the patch applied, but perhaps it still uses the unpatched 
scripts. Could you clarify just for my own understanding, please? 
                
> precommit tests only check toplevel rat file, not the one for submodules.
> -------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-483
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: 
> 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
>
>
> Therefore, not all rat errors are detected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to