[
https://issues.apache.org/jira/browse/BOOKKEEPER-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526191#comment-13526191
]
Hadoop QA commented on BOOKKEEPER-493:
--------------------------------------
Testing JIRA BOOKKEEPER-493
Patch
[BOOKKEEPER-493.diff|https://issues.apache.org/jira/secure/attachment/12559825/BOOKKEEPER-493.diff]
downloaded at Fri Dec 7 07:01:27 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:red}-1{color} the patch contains 1 line(s) with trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 395
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/79/
> moveLedgerIndexFile might have chance pickup same directory
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-493
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-493
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-493.diff
>
>
> {code}
> public void addToFilledDirs(File dir) {
> if (!filledDirs.contains(dir)) {
> LOG.warn(dir + " is out of space."
> + " Adding it to filled dirs list");
> // Update filled dirs list
> List<File> updatedFilledDirs = new ArrayList<File>(filledDirs);
> updatedFilledDirs.add(dir);
> filledDirs = updatedFilledDirs;
> // Update the writable ledgers list
> List<File> newDirs = new
> ArrayList<File>(writableLedgerDirectories);
> newDirs.removeAll(filledDirs);
> writableLedgerDirectories = newDirs;
> // Notify listeners about disk full
> for (LedgerDirsListener listener : listeners) {
> listener.diskFull(dir);
> }
> }
> }
> {code}
> When a directory is putting into filledDirs, it might not be removed from
> writableLedgerDirectories. The directory still has chance to be picked up to
> move index file.
> we need same synchronization and check to guarantee that we don't move to
> same directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
