[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527153#comment-13527153
 ] 

Flavio Junqueira commented on BOOKKEEPER-491:
---------------------------------------------

Thanks for the review, Sijie.

bq. This setting is not recommended. Users are suggested to enable cross region 
ssl connections in conf/hw_region_client.conf

I don't know what you want me to say in the textile file, so haven't done 
anything about it.

bq. this password setting is for ssl cert file not for bookkeeper. currently we 
had a hardcode 'silly' password in Hedwig.

Fixed.

bq. Do we need a separated jira to expose it as a setting?

Maybe so. If no one has actually needed it, then I would leave as is for now.

bq. there is some configurations missed in conf/hw_server.conf after some 
recent changes. could you help putting them in conf/hw_server.conf too?

I've found only three parameters missing. If see you any other parameter 
missing, please let me know or add it directly and generate a new patch.

bq. do you mind putting the setting about crossing region client settings in 
this documentation too? you could find them in conf/hw_region_client.conf

Done.
                
> Hedwig doc for configuration
> ----------------------------
>
>                 Key: BOOKKEEPER-491
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-491
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Blocker
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-491.patch, BOOKKEEPER-491.patch
>
>
> Unless I'm not looking properly into it, I can's see any doc describing the 
> configuration parameters of hedwig-server. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to