[
https://issues.apache.org/jira/browse/BOOKKEEPER-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528916#comment-13528916
]
Hadoop QA commented on BOOKKEEPER-497:
--------------------------------------
Testing JIRA BOOKKEEPER-497
Patch
[0001-BOOKKEEPER-497-GcLedgersTest-has-a-potential-race.patch|https://issues.apache.org/jira/secure/attachment/12560166/0001-BOOKKEEPER-497-GcLedgersTest-has-a-potential-race.patch]
downloaded at Tue Dec 11 12:01:43 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 439
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/97/
> GcLedgersTest has a potential race
> ----------------------------------
>
> Key: BOOKKEEPER-497
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-497
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-497-GcLedgersTest-has-a-potential-race.patch
>
>
> The callbacks use Object#wait/notify without checking a condition. If the
> callback completes very quickly, the notify will happen before wait is ever
> called. The best solution is to use a CountDownLatch. Im seeing this problem
> when applying patch for BOOKKEEPER-205, probably due to a change in timing on
> the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
