[
https://issues.apache.org/jira/browse/BOOKKEEPER-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533966#comment-13533966
]
Ivan Kelly commented on BOOKKEEPER-500:
---------------------------------------
Patch looks good. It's good that the idx format is backward compatible also.
I've 2 comments. Firstly, you need to bump
JournalChannel#CURRENT_JOURNAL_FORMAT_VERSION, and check for _that_ version
when replaying the journal. Secondly, you catch Exception in processPacket,
which will fail findbugs. Otherwise, the fix looks ready.
> Fencing doesn't work when restarting bookies.
> ---------------------------------------------
>
> Key: BOOKKEEPER-500
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-500
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.1.0, 4.2.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Priority: Blocker
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-500.diff, BOOKKEEPER-500.-testcase.diff
>
>
> Currently we just record fence state in memory. If the bookies are restarted,
> all fence states are gone. It would break the correctness that we guarantee
> about fencing.
> We should record the fence state in the file info to make it persistent.
> A test case added to produce this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
