[
https://issues.apache.org/jira/browse/BOOKKEEPER-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537201#comment-13537201
]
Uma Maheswara Rao G commented on BOOKKEEPER-293:
------------------------------------------------
Thanks Ivan for the patch! Below is my feedback on the patch.
- AuditorPeriodicCheckTest:
did not write the buffer anywhere in test.
{code}
ByteBuffer junk = ByteBuffer.allocate(1024*1024);
for (File f : entryLogs) {
FileOutputStream out = new FileOutputStream(f);
out.close();
}
{code}
- Worth having a log whether we enabled this service or not as we have the flag
and also log with period.
- Do you think we should consider Autorecovery enable/disable flag to run this
service as we may stop Bookies because of maintanence, that time if this
service runs then it may identify lot of ledgers as under-replicated and even
though RW won't process them immediately until the service enabled, it may
spend on unnecesary checkings once enabled.
- Now publishSuspectedLedgers may be called concurrently right? (regular
auditing and this periodic check)
> Periodic checking of ledger replication status
> ----------------------------------------------
>
> Key: BOOKKEEPER-293
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-293
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-293-Periodic-checking-of-ledger-replicati.patch,
> 0002-BOOKKEEPER-293-Periodic-checking-of-ledger-replicati.patch,
> 0002-BOOKKEEPER-293-Periodic-checking-of-ledger-replicati.patch
>
>
> We should periodically check all ledgers to make sure that they are fully
> replicated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
