[
https://issues.apache.org/jira/browse/BOOKKEEPER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539453#comment-13539453
]
Uma Maheswara Rao G commented on BOOKKEEPER-409:
------------------------------------------------
Patch looks mostly good. I have some minor stuff to address.
- I think we should add javadoc for BookKeeperClusterBaseTest.
- {code}
private void killBookieAndRecoveryService(
+ InetSocketAddress replicaToKillAddr) throws InterruptedException {
+ LOG.info("Killing Bookie :" + replicaToKillAddr);
+ killBookie(replicaToKillAddr);
+ }
{code}
I think this extra delegation may not be required right, because Bookie stop it
self will take care of killing recovery service right as startBookie is
starting that service?
> Integration Test - Perform bookie rereplication cycle by Auditor-RW processes
> -----------------------------------------------------------------------------
>
> Key: BOOKKEEPER-409
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-409
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.2.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Labels: test
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-409-1.patch, BOOKKEEPER-409-2.patch,
> BOOKKEEPER-409.patch
>
>
> The idea is to perform integration testing of entire re-replication module :
> Auditor-RW processes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
