[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540195#comment-13540195
 ] 

Flavio Junqueira commented on BOOKKEEPER-524:
---------------------------------------------

I'm wondering if shutting down the bookie is really the best course of action 
in the case of an unexpected exception. What happens if we restart the sync 
thread? What if we just continue to the next iteration of the while loop? 

Also, it would be good to have a test case. Is it doable to produce a test case 
out of the scenario that sijie mentioned?
                
> Bookie journal filesystem gets full after SyncThread is terminated with 
> exception
> ---------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-524
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-524
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.2.0
>            Reporter: Matteo Merli
>            Priority: Blocker
>             Fix For: 4.2.0
>
>         Attachments: 
> 0001-BOOKKEEPER-524-Bookie-journal-filesystem-gets-full-a.patch, 
> 0001-BOOKKEEPER-524-Bookie-journal-filesystem-gets-full-a.patch
>
>
> The SyncThread get a NPE while the rest of the bookie is still running. This 
> causes the journal gc to be stopped and the filesystem get full.
> Tue Dec 18 17:01:18 2012: Exception in thread "SyncThread" 
> java.lang.NullPointerException
> Tue Dec 18 17:01:18 2012:       at 
> org.apache.bookkeeper.bookie.LedgerCacheImpl.getLedgerEntryPage(LedgerCacheImpl.java:153)
> Tue Dec 18 17:01:18 2012:       at 
> org.apache.bookkeeper.bookie.LedgerCacheImpl.flushLedger(LedgerCacheImpl.java:421)
> Tue Dec 18 17:01:18 2012:       at 
> org.apache.bookkeeper.bookie.LedgerCacheImpl.flushLedger(LedgerCacheImpl.java:363)
> Tue Dec 18 17:01:18 2012:       at 
> org.apache.bookkeeper.bookie.InterleavedLedgerStorage.flush(InterleavedLedgerStorage.java:148)
> Tue Dec 18 17:01:18 2012:       at 
> org.apache.bookkeeper.bookie.Bookie$SyncThread.run(Bookie.java:221)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to