[
https://issues.apache.org/jira/browse/BOOKKEEPER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542462#comment-13542462
]
Hudson commented on BOOKKEEPER-55:
----------------------------------
Integrated in bookkeeper-trunk2 #24 (See
[https://builds.apache.org/job/bookkeeper-trunk2/24/])
BOOKKEEPER-55: SubscribeReconnectRetryTask might retry subscription
endlessly when another subscription is already successfully created previously
(sijie via ivank) (Revision 1428059)
Result = SUCCESS
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/data/PubSubData.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/exceptions/ResubscribeException.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/CleanupChannelMap.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/AbstractSubscribeResponseHandler.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/ActiveSubscriber.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/ResubscribeCallback.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/multiplex/MultiplexHChannelManager.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/multiplex/MultiplexSubscribeResponseHandler.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/simple/SimpleHChannelManager.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/simple/SimpleSubscribeResponseHandler.java
*
/zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/exceptions/PubSubException.java
*
/zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protocol/PubSubProtocol.java
*
/zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/protobuf/PubSubProtocol.proto
*
/zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/client/TestPubSubClient.java
*
/zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java
> SubscribeReconnectRetryTask might retry subscription endlessly when another
> subscription is already successfully created previously
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-55
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-55
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 4.0.0
> Reporter: Gavin Li
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-55.patch, BOOKKEEPER-55.patch, patch
>
>
> For channelDisconnected envent, we try to automatically recover the
> connection and subscription. But when users call HedwigSubscriber.subscribe()
> at the same time, it might succeed before the auto recovery. Then the auto
> recovery can never succeed as the server will report topic busy failure. Then
> the SubscribeReconnectRetryTask will retry again and again endlessly. We
> found this in our auto test.
> Fix is easy, we just need to firstly check if the channel for this topic and
> subscribe id is null, if not it means some subscription is already created
> before, we don't need to bother recover.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
