[
https://issues.apache.org/jira/browse/BOOKKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585315#comment-13585315
]
Rakesh R commented on BOOKKEEPER-572:
-------------------------------------
Hi Ivan,
Nice work and thanks for perf testing efforts. I'm interested to see yourkit
snapshot, could you pls share it. Also, would like to know more about the test
scenario executed while taking the perf and profiling reports.
Just few suggestions,
- How about using queue.offer(new QueueEntry, long timeout, TimeUnit unit) and
propagate proper errorcode/exception, instead of queue.put(new QueueEntry);.
This way we would do a graceful handling rather than blocking indefinitely. I'm
afraid of hanging eventhough its a corner case, also now the queue limit is
visible and user can tune it.
- IMHO not to use a LinkedBlockingQueue in a performance sensitive area of
code, use an ArrayBlockingQueue, anyway we are making the queue unbounded with
this patch. I feel, ArrayBlockingQueue gives much more perf.
-Rakesh
> Make the journal a write ahead log
> ----------------------------------
>
> Key: BOOKKEEPER-572
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-572
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0003-BOOKKEEPER-572-Write-to-the-journal-before-writing-t.patch
>
>
> A bookie adds to the LedgerStorage before writing to the journal. This is the
> fundamental problem behind BOOKKEEPER-447 and blocks a nice solution to
> BOOKKEEPER-530. By writing to the memory state before the journal, we exposed
> ourselves to bugs if the bookie crashed before we wrote to the journal. The
> entry may exist in index, but not in the entrylog, a situation which cannot
> be distinguished from an I/O error. The comments on BOOKKEEPER-447 goes into
> more details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
