[
https://issues.apache.org/jira/browse/BOOKKEEPER-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587190#comment-13587190
]
Hadoop QA commented on BOOKKEEPER-576:
--------------------------------------
Testing JIRA BOOKKEEPER-576
Patch
[0002-BOOKKEEPER-576-Bookie-client-should-use-netty-Decode.patch|https://issues.apache.org/jira/secure/attachment/12570985/0002-BOOKKEEPER-576-Bookie-client-should-use-netty-Decode.patch]
downloaded at Tue Feb 26 14:50:31 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 817
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/278/
> Bookie client should use netty Decoder/Encoder
> ----------------------------------------------
>
> Key: BOOKKEEPER-576
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-576
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0002-BOOKKEEPER-576-Bookie-client-should-use-netty-Decode.patch
>
>
> Current it encodes and decodes in an adhoc manner in PerChannelBookieClient.
> It would be better to have the request encoding and decoding in the same
> place and it should also be done with a OneToOne*coder like is done with the
> server.
> This will make it easier to add a versioning decoder, which will make it much
> easier to extend the bookie protocol.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
