[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593915#comment-13593915
 ] 

Sijie Guo commented on BOOKKEEPER-580:
--------------------------------------

[~rakeshr] 

> There is an unncessary import in LedgerHandle.java.

I could not be noticed since I used vim rather than an IDE. I think we should 
integrate checkstyle rather than ask someone to remove unnecessary imports by 
comments.

> Do we need double check?, I feel we can have only one which is inside the 
> SafeRunnable. 

I don't want to let lots of runnables propagated during failures, it might 
cause memory issue during a high throughput case. 
                
> improve close logic
> -------------------
>
>                 Key: BOOKKEEPER-580
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-580
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-580.diff
>
>
> currently, bookkeeper client still write ledger metadata to metadata storage 
> even the metadata is already closed or undergoing closing. which would cause 
> lots of bad version metadata update encountering unrecoverable errors in 
> ledger handle. e.g. NotEnoughtBookiesException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to