[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638775#comment-13638775
]
Rakesh R commented on BOOKKEEPER-564:
-------------------------------------
Thanks Ivan and Sijie for the great effort and your time. Sorry for pitching
late, I'm busy with our internal releases and other schedules:(
Its very nice idea to avoid frequent checkpointing, which affects performance.
Hi [[email protected]], patch looks good and I'm just having one thought.
bq.•LedgerStorage decides when to checkpoint, and runs it autonomously
If I understand your approach, LedgerStorage owns the checkpoint thread.
#onRotateEntryLog it will run the checkpointing and updates the lastSyncedMark.
There is no problem with this approach. In this case, when a new LedgerStorage
implementation comes in, it should again re-define the checkpointing algo.
IMHO, instead of this can we think of an approach where we can decouple the
checkpointing algo from Interleaved storage. Bookie can own this checkpointing
logic and let him control. With this approach Bookie will have more control
over the checkpointing irrespective of the plugged-in ledger storage. How does
it sound?. [~hustlmsp], are you also thinking in similar way?
Thanks,
Rakesh
> Better checkpoint mechanism
> ---------------------------
>
> Key: BOOKKEEPER-564
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-564
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> 0002-BOOKKEEPER-564-Better-checkpoint-mechanism.patch, BOOKKEEPER-564.patch,
> BOOKKEEPER-564.patch
>
>
> Currently, SyncThread made a checkpoint too frequently, which affects
> performance. data is writing to entry logger file might be blocked by syncing
> same entry logger file, which affect bookie to achieve higher throughput. We
> could schedule checkpoint only when rotating an entry log file. so new
> incoming entries would be written to newer entry log file and old entry log
> file could be synced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
