[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645193#comment-13645193
]
Rakesh R commented on BOOKKEEPER-564:
-------------------------------------
Thanks [[email protected]], [~hustlmsp] for the patch. Just few comments.
- Following are not used anywhere, can we remove these?
{code}
public static final Checkpoint MIN = new Checkpoint() {
static final public LogMark MAX_VALUE = new LogMark(Long.MAX_VALUE,
Long.MAX_VALUE);
{code}
- Just make the LogMarkCheckpoint to 'private'
private static class LogMarkCheckpoint implements Checkpoint {
- I think, journal.checkpointComplete() can mark the checkpoint completion only
when the
journal.newCheckpoint().compareTo(lastcheckpoint) > 0
- One general thought. Is it required to do checkpointing, once bookie marked
as readonly?
> Better checkpoint mechanism
> ---------------------------
>
> Key: BOOKKEEPER-564
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-564
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> 0001-BOOKKEEPER-584-CheckpointSource.patch,
> 0002-BOOKKEEPER-564-Better-checkpoint-mechanism.patch, BOOKKEEPER-564.patch,
> BOOKKEEPER-564.patch, BOOKKEEPER-564.patch
>
>
> Currently, SyncThread made a checkpoint too frequently, which affects
> performance. data is writing to entry logger file might be blocked by syncing
> same entry logger file, which affect bookie to achieve higher throughput. We
> could schedule checkpoint only when rotating an entry log file. so new
> incoming entries would be written to newer entry log file and old entry log
> file could be synced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
